Completely agree! It’s SO much easier to lighten the mood and keep things upbeat and productive in an actual conversation vs. just text-based feedback. For example it makes it easy to throw in self-deprecating anecdotes of your own when discussing mistakes / needed changes, which can really help put juniors at ease. It’s just worlds better in >90% of scenarios.

Completely understand the frustration here. Mistakes happen, even competent people sincerely trying to do a good job can overlook things, etc. But if it’s a pattern of just copying and pasting code without really even trying to understand what it does, that’s a big problem that needs to be addressed. And frankly they should feel embarrassed if it happens more than once or twice.

OTOH, delivering criticism in a way that winds up productive for all involved is difficult at best, and the outcome depends on the junior as much as it does the senior. What good is being right if it ultimately just alienates you from your team? Tough situation for sure, and one of the many reasons it’s so important to hire carefully (which is itself a whole huge can of worms too!).

Can you simply ask them to walk through their submission line by line with you, explaining what it’s doing? If you’ve never asked that before it might come across as a strange request, but if you phrase it well it’s possible this causes them to notice their poor understanding without you ever seeming to point it out.

Actually after a re-read, you were constructive and made reasonable points throughout. My bad, I dunno why I interpreted that last one so harshly, wasn’t really my business anyway.

What a dismissive, reductive response. As if your point of view is the only one with any merit.

Just want to back you up here and say the deeper ethos sometimes DOES matter. People need to stop acting like a piece of generally good advice applies to every situation ever. The “stop gatekeeping” pendulum has swung a bit too far (although the principle is great and, incidentally, punk as fuck!).

When did we decide everything has to be for everyone, and everyone has a right to participate in everything, just by virtue of existing? What would these folks say to someone who walks around in - e.g., Sikh cultural accoutrement - but has zero interest (and even a snobbish disdain) for the underlying religion? “Good for them, we shouldn’t gatekeep”? Fuck outta here.

On the one hand, all culture and art is syncretic, full stop. I’m not saying punk rock is off limits in any way, that’d be absurd. But at this point it’s got what, like 40 years of maintaining a broadly consistent ethos or spirit? That’s remarkable, it’s valuable, and it’s only been possible because of gatekeeping - passionate community members putting forth effort to maintain the community identity. In a time when every damn thing of cultural significance is being hollowed out and commoditized for profit, we should all celebrate punk rock staying punk.

I just don’t agree that most folks mean the middle panel. It really depends who and where you ask. A lot of people have - for example - a big problem with Affirmative Action because it looks like the middle panel - different help given to different people.

I think it depends a lot on the people using the words. People who don’t believe that the systematized slavery as practiced in the US produced long-lasting generational effects, for example, might say that treating people equally moving forward is best. Under that belief system, everyone starts on ~even footing and gets the same opportunities, so actually it’s less fair to make special cases for folks!

In my view those folks are starting from a deeply flawed premise (and usually one they’ve arrived at in order to justify the worldview they already hold), so their conclusions are worthless. But I think they’d meet the criteria of advocating for equality and against equity, and sincerely mean it. It’s not hypothetical either, I’ve met people like this - depressingly many, in fact.

Excellent work, and thank you for sharing. What a win! I’m always heartened to hear about straightforward open source wins against leeches 👍